RussellSpitzer opened a new issue, #17802: URL: https://github.com/apache/iceberg/issues/17802
> After review, this is not considered a serious vulnerability that needs to be kept private. It is the same class as #16469 (`Class.forName` / constructor load of a name already on the classpath; no new bytecode). Filed publicly as optional hardening. # Summary `GenericAvroReader` uses Avro record full names as Java class names (`Class.forName` with initialize true). If the class implements `IndexedRecord`, Iceberg then constructs it and populates fields. Those names come from schema JSON, including `AvroEncoderUtil.decode`, which embeds a writer schema in the blob (`0xC2 0x01` + schema string). Kafka Connect control-topic messages and `ManifestFiles.decode` use that decoder. This is not an intended SPI (unlike `write.location-provider.impl` in #16469). Decode can use `GenericData.Record` or the allowlist already used on encode (`org.apache.iceberg.connect.events.AvroUtil.FIELD_ID_TO_CLASS`) instead of loading arbitrary classpath names. # Affected Maven coordinates * primary shipped client artifact: `org.apache.iceberg:iceberg-core` * also: `org.apache.iceberg:iceberg-kafka-connect` (control events via `AvroEncoderUtil`) # Attacker prerequisites * ability to supply Avro schema JSON that Iceberg will parse with `GenericAvroReader` (e.g. produce to a Kafka Connect control topic, or an Avro file the process will read) * a gadget class already on that process classpath with a dangerous static initializer, or an `IndexedRecord` with a dangerous constructor # Impact * Triggers class initialization (and, for `IndexedRecord`, construction) of an already-loaded classpath type * Does not load new bytecode from the network * Practical severity matches #16469 unless a suitable gadget is present # Proof status Source review only. The issue is visible directly from source. # Key source references * `org.apache.iceberg.avro.GenericAvroReader` (`recordReader`, `DynClasses`) * `org.apache.iceberg.avro.AvroEncoderUtil` (`decode`) * `org.apache.iceberg.connect.events.AvroUtil` # Related * #16469 — metadata-driven class names (`LocationProviders`, catalog impl properties); closed as not a vulnerability -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
