twuebi opened a new pull request, #1875: URL: https://github.com/apache/iceberg-go/pull/1875
The two loops in the load table decoding benchmark trip intrange, which .golangci.yml enables, so the tree does not lint clean. Converting makeTableResponseWithSnapshots also fixes a bug the old form hid. The C-style loop shares one i across all iterations, so parentID = &i stored the same address in every snapshot, and the slice is marshalled only after the loop exits: every snapshot reported the same parent, the post-loop value of i. Range-over-int gives each iteration its own i, so each snapshot now reports its own index. The fixture still makes each snapshot its own parent rather than its predecessor, which is pre-existing and does not change the response size the benchmark measures. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
