Copilot commented on code in PR #3851:
URL: https://github.com/apache/iceberg-python/pull/3851#discussion_r3851483559
##########
.github/workflows/svn-build-artifacts.yml:
##########
@@ -71,8 +75,10 @@ jobs:
# Ignore 32 bit architectures
CIBW_ARCHS: "auto64"
Review Comment:
This PR’s intent is to add Windows ARM64 wheels, but `CIBW_ARCHS: auto64`
doesn’t explicitly constrain the Windows architecture to ARM64. To reduce the
risk of producing the wrong Windows wheel arch (e.g., AMD64 on an ARM runner,
depending on available interpreters/emulation), consider setting
`CIBW_ARCHS_WINDOWS` explicitly for the `windows-11-arm` matrix entry (e.g.,
via a matrix field) so the ARM64 job is guaranteed to build ARM64 wheels.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]