kbendick commented on a change in pull request #2062:
URL: https://github.com/apache/iceberg/pull/2062#discussion_r554674081
##########
File path:
api/src/main/java/org/apache/iceberg/expressions/BoundLiteralPredicate.java
##########
@@ -69,6 +69,8 @@ public boolean test(T value) {
return cmp.compare(value, literal.value()) != 0;
case STARTS_WITH:
return String.valueOf(value).startsWith((String) literal.value());
+ case NOT_STARTS_WITH:
+ return !String.valueOf(value).startsWith((String) literal.value());
Review comment:
Should we be using the predefined comparators here? This seems like it
could get iffy with non-ascii values given the difference between UTF-8 and
Java's default String encoding of UTF-16.
I chose to go with the existing style here, but I'm not 100% convinced this
is the best solution as opposed to using a comparator.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
