pvary commented on code in PR #16125:
URL: https://github.com/apache/iceberg/pull/16125#discussion_r3852149892
##########
core/src/test/java/org/apache/iceberg/TestMetadataTableScans.java:
##########
@@ -684,6 +684,25 @@ public void partitionsTableReusesPartitionDataSchema() {
assertThat(partitionSchemas).allSatisfy(schema ->
assertThat(schema).isSameAs(expectedSchema));
}
+ @TestTemplate
+ public void testPartitionsTableDvCount() {
+ assumeThat(formatVersion).isGreaterThanOrEqualTo(3);
+
+ table.newFastAppend().appendFile(FILE_A).appendFile(FILE_B).commit();
+ table.newRowDelta().addDeletes(FILE_A_DV).addDeletes(FILE_B_DV).commit();
Review Comment:
Could we at least confirm that the dv_count is added when we have multiple
DVs in a partition, and it is the file number and not the record number?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
