plusplusjiajia commented on code in PR #893:
URL: https://github.com/apache/iceberg-cpp/pull/893#discussion_r3855381606
##########
src/iceberg/test/arrow_s3_file_io_test.cc:
##########
@@ -191,8 +191,8 @@ TEST_F(ArrowS3FileIOTest, SkipsNonS3CredentialPrefix) {
// credential that is silently skipped leaves S3 access on the default
// credentials, which only surfaces much later as an auth error.
TEST_F(ArrowS3FileIOTest, AppliesEveryS3CompatibleCredentialPrefix) {
- for (std::string_view prefix :
- {"s3", "s3://bucket/table", "s3a://bucket/table",
"s3n://bucket/table"}) {
+ for (std::string_view prefix : {"s3", "s3://bucket/table",
"s3a://bucket/table",
+ "s3n://bucket/table", "oss://bucket/table"})
{
Review Comment:
@wgtmac Both — renamed to `Accepts…` and added a gated
`AppliesOssCredentialInRealRoundTrip` that fails unless the oss credential is
canonicalized and selected.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
