marton-bod commented on a change in pull request #2052:
URL: https://github.com/apache/iceberg/pull/2052#discussion_r554885653
##########
File path: mr/src/main/java/org/apache/iceberg/mr/hive/HiveIcebergSerDe.java
##########
@@ -66,9 +67,7 @@ public void initialize(@Nullable Configuration configuration,
Properties serDePr
assertNotVectorizedTez(configuration);
Schema tableSchema;
- if (configuration.get(InputFormatConfig.TABLE_SCHEMA) != null) {
- tableSchema =
SchemaParser.fromJson(configuration.get(InputFormatConfig.TABLE_SCHEMA));
- } else if (serDeProperties.get(InputFormatConfig.TABLE_SCHEMA) != null) {
+ if (serDeProperties.get(InputFormatConfig.TABLE_SCHEMA) != null) {
Review comment:
Hi @qphien . Indeed, we have had a similar problem before in
https://github.com/apache/iceberg/issues/1708.
My initial solution to fix it was to add the schema into the config object
with a prefix based on the table identifier. For example, when joining together
default.orders and default.customers, you'd have two properties in the config:
`default.orders.iceberg.mr.table.schema` and
`default.customers.iceberg.mr.table.schema`. This should allow you to add the
schema for multiple tables without collisions/overwrites.
Eventually we ended up not adding in this fix, but instead just reverted the
commit that caused the problem for us. However, this prefix solution can be one
way to make things work.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
