badalprasadsingh commented on code in PR #1856:
URL: https://github.com/apache/iceberg-go/pull/1856#discussion_r3857621362
##########
table/snapshot_producers.go:
##########
@@ -788,6 +798,10 @@ func (sp *snapshotProducer) buildManifests(ctx
context.Context, parent *Snapshot
// written once and reused verbatim across OCC retries (rewriting them would
// churn manifest paths and orphan object-store files on every attempt).
func (sp *snapshotProducer) addedContentManifests() ([]iceberg.ManifestFile,
error) {
+ if err := sp.validateAddedSpecs(); err != nil {
Review Comment:
Done.
Now we have single validateSpecs in buildManifests and assembleManifests,
covering deletedFiles, deletedDeleteFiles and deletedDVsByRef.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
