mcc0nnell opened a new pull request, #105:
URL: https://github.com/apache/terraform-provider-iceberg/pull/105
Fixes #102.
RC convenience binaries are named `0.1.0` via `GORELEASER_CURRENT_TAG`, but
Go 1.24+ stamps `debug.BuildInfo.Main.Version` from the VCS tag actually
present at HEAD (`v0.1.0-rc2`). `release.sh` then promotes those binaries
bit-for-bit, so `go version -m` on the final artifact reports the RC version.
This does not document the mismatch (see #104) and does not rebuild after
the vote. During the RC binary job we create an ephemeral local-only
lightweight tag `v${VERSION}` at the RC commit so Go 1.25.8 selects the highest
semver (`v0.1.0` > `v0.1.0-rc2`) while `vcs.revision` remains the RC SHA. That
tag is never pushed: workflow `contents: read`, checkout `persist-credentials:
false`, and the step does not run `git push`. The published `vX.Y.Z` tag is
still created by `release.sh` only after the vote.
A conflicting pre-existing `v${VERSION}` tag that does not point at HEAD
fails closed. After GoReleaser, every provider ZIP is checked with `go version
-m`: module version must be `v${VERSION}`, `vcs.revision` must equal HEAD,
`vcs.modified` must be `false`.
Does not change source-release, signing, or ASF voting semantics.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
