Copilot commented on code in PR #901: URL: https://github.com/apache/iceberg-cpp/pull/901#discussion_r3861637379
########## .github/workflows/stale-prs.yml: ########## @@ -0,0 +1,49 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Borrowed the file from Apache Iceberg-Java: +# https://github.com/apache/iceberg/blob/main/.github/workflows/stale.yml + +name: "Close Stale Issues and PRs" +on: + schedule: + - cron: '0 0 * * *' + +permissions: + # All other permissions are set to none + issues: write + pull-requests: write + +jobs: + stale: + if: github.repository_owner == 'apache' + runs-on: ubuntu-slim Review Comment: `ubuntu-slim` is not a valid GitHub-hosted runner label, so this workflow will fail to start. Use a supported runner label like `ubuntu-latest` (or a pinned version such as `ubuntu-24.04`) instead. ########## .github/workflows/stale-prs.yml: ########## @@ -0,0 +1,49 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Borrowed the file from Apache Iceberg-Java: +# https://github.com/apache/iceberg/blob/main/.github/workflows/stale.yml + +name: "Close Stale Issues and PRs" +on: + schedule: + - cron: '0 0 * * *' + +permissions: + # All other permissions are set to none + issues: write + pull-requests: write + +jobs: + stale: + if: github.repository_owner == 'apache' + runs-on: ubuntu-slim + steps: + - uses: actions/stale@4391f3da665fdf50b6810c1a66712fb9ba21aa93 # v11.0.0 + with: + # Don't touch issues. + days-before-issue-stale: -1 + days-before-issue-close: -1 Review Comment: The workflow name says it closes stale issues and PRs, but the configuration explicitly disables issue handling. Rename the workflow to reflect PR-only behavior (e.g., \"Close Stale PRs\"), or enable issue staleness/closing to match the current name. ########## .github/workflows/stale-prs.yml: ########## @@ -0,0 +1,49 @@ +# Licensed to the Apache Software Foundation (ASF) under one +# or more contributor license agreements. See the NOTICE file +# distributed with this work for additional information +# regarding copyright ownership. The ASF licenses this file +# to you under the Apache License, Version 2.0 (the +# "License"); you may not use this file except in compliance +# with the License. You may obtain a copy of the License at +# +# http://www.apache.org/licenses/LICENSE-2.0 +# +# Unless required by applicable law or agreed to in writing, +# software distributed under the License is distributed on an +# "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY +# KIND, either express or implied. See the License for the +# specific language governing permissions and limitations +# under the License. + +# Borrowed the file from Apache Iceberg-Java: +# https://github.com/apache/iceberg/blob/main/.github/workflows/stale.yml + +name: "Close Stale Issues and PRs" Review Comment: The workflow name says it closes stale issues and PRs, but the configuration explicitly disables issue handling. Rename the workflow to reflect PR-only behavior (e.g., \"Close Stale PRs\"), or enable issue staleness/closing to match the current name. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
