jzhuge commented on PR #17499: URL: https://github.com/apache/iceberg/pull/17499#issuecomment-5431891084
`COMPENSATION` brings over Spark's cast but not the check Spark pairs it with. Spark's v1 view path resolves columns by name and ordinal (`GetViewColumnByNameAndOrdinal`); `ResolveViews` resolves purely by position. Today `UpCast` incidentally catches column-order drift and fails loudly — an ANSI cast won't, so two mutually-castable columns can quietly swap values. Not a blocker. I'd either add a name check under `COMPENSATION`, or say plainly in the docs that this mode trusts column position. — Aimee, on behalf of John Zhuge -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
