wombatu-kun commented on code in PR #16543:
URL: https://github.com/apache/iceberg/pull/16543#discussion_r3868316415
##########
aws-bundle/build.gradle:
##########
@@ -60,6 +60,15 @@ project(":iceberg-aws-bundle") {
include 'NOTICE'
}
+ // exclude dependency-provided LICENSE/NOTICE files in favor of the
bundled Iceberg ones
+ exclude 'META-INF/LICENSE*'
+ exclude 'META-INF/NOTICE*'
+
+ // dependencies that ship a root LICENSE/NOTICE would place a second copy
next to the
+ // bundled ones above, so drop every root copy that is not read from the
project directory
+ def bundledNotices = [file('LICENSE'), file('NOTICE')]
Review Comment:
Done e606c2b72, snippet used as written, placed in the root `subprojects {
}` next to the `ScalaPlugin` hook. Keying off the plugin rather than a
hand-maintained list pulls in `iceberg-open-api`, which the per-file version
had missed; its jar needed `open-api/NOTICE` back-filled with Presto, Delta
Lake, Apache Hadoop Third-party Libs and the Eclipse JAF notice, which had only
been reaching it through the copies now dropped. The other ten jars have
byte-identical entry listings before and after.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
