hedger9487 commented on code in PR #3854:
URL: https://github.com/apache/iceberg-python/pull/3854#discussion_r3868941446
##########
pyiceberg/transforms.py:
##########
@@ -896,11 +896,7 @@ def truncate_func(v: Any) -> Any:
def satisfies_order_of(self, other: Transform[S, T]) -> bool:
if self == other:
return True
- elif (
Review Comment:
Makes sense! Took this opportunity to clean up `_source_type` and the
`source_type` property as well, and expanded the unit test suite to verify
cross-transform comparisons and attribute cleanup.
Thanks for the review, @rambleraptor!
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
