blackmwk commented on code in PR #3044:
URL: https://github.com/apache/iceberg-rust/pull/3044#discussion_r3871700178
##########
crates/property-macro/tests/properties.rs:
##########
@@ -260,6 +261,126 @@ fn
custom_single_value_parser_wraps_present_optional_values() {
assert!(format!("{error}").contains("property: optional-location"));
}
+properties_view! {
Review Comment:
Done. Moved the properties_view! integration tests into their own
tests/properties_view.rs test module.
##########
crates/property-macro/tests/compile_fail.rs:
##########
@@ -16,6 +16,11 @@
// under the License.
#[test]
-fn reports_invalid_property_annotations() {
+fn reports_invalid_properties_derive_declarations() {
trybuild::TestCases::new().compile_fail("tests/compile-fail/*.rs");
Review Comment:
Done. Moved all derive macro compile-fail fixtures into
tests/compile-fail/derive-properties/, updated the trybuild glob, and
regenerated the expected diagnostic paths.
##########
crates/property-macro/tests/properties_derive.rs:
##########
Review Comment:
Done. Renamed the existing derive integration test module from properties.rs
to properties_derive.rs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
