fallintoplace opened a new pull request, #1922: URL: https://github.com/apache/iceberg-go/pull/1922
## What changed - Reuse the delete file decoded before resolving task references when a Puffin deletion vector already includes `referenced-data-file`. - Keep the existing second decode when that field is omitted. - Keep the existing owner validation and deletion-vector behavior unchanged. - Add a benchmark for explicit and derived deletion-vector ownership. ## Benchmark Ran on an Apple M1 Pro (`darwin/arm64`) with Go `go1.26.3`. ```text go test ./catalog/rest -run '^$' -bench '^BenchmarkDecodeScanTasksDeletionVectors$' -benchmem -count=5 -benchtime=1s ``` Median of 5 runs: | Owner | Tasks | ns/op before | ns/op after | B/op before -> after | allocs/op before -> after | | --- | ---: | ---: | ---: | ---: | ---: | | explicit | 100 | 936382 | 635246 | 1511743 -> 1014941 | 12712 -> 8412 | | derived | 100 | 958570 | 911513 | 1510143 -> 1510142 | 12612 -> 12612 | | explicit | 1000 | 11346750 | 6137807 | 15153473 -> 10185471 | 127023 -> 84023 | | derived | 1000 | 11135820 | 11817984 | 15137478 -> 15137484 | 126023 -> 126023 | | explicit | 10000 | 127284729 | 61087905 | 151295556 -> 101615522 | 1270082 -> 840082 | | derived | 10000 | 103055288 | 89958272 | 151135522 -> 151135542 | 1260082 -> 1260082 | The explicit-owner path removes about one decode per referenced deletion vector. The derived-owner control keeps the fallback allocation profile unchanged. ## Checks - `go test ./...` - `go vet ./...` - `go test -race ./catalog/rest` -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
