mattfaltyn commented on code in PR #1905:
URL: https://github.com/apache/iceberg-go/pull/1905#discussion_r3875555494
##########
table/update_schema_test.go:
##########
@@ -887,6 +887,47 @@ func TestMoveColumn(t *testing.T) {
})
}
+func TestMoveRelativeToDeletedColumnRejected(t *testing.T) {
+ tests := []struct {
+ name string
+ build func(*UpdateSchema) *UpdateSchema
+ }{
+ {
+ name: "delete then move before",
+ build: func(update *UpdateSchema) *UpdateSchema {
+ return
update.DeleteColumn([]string{"name"}).MoveBefore([]string{"age"},
[]string{"name"})
Review Comment:
> “one nested case would pin that path down”
Nice call — added a nested `address.city` target case to exercise the
parent-ID bucket.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
