xanderbailey commented on code in PR #2651:
URL: https://github.com/apache/iceberg-rust/pull/2651#discussion_r3873714150
##########
crates/catalog/rest/src/catalog.rs:
##########
@@ -1465,8 +1484,10 @@ impl SessionCatalog for RestSessionCatalog {
}
};
+ // The commit response carries no credentials, so build a plain FileIO;
+ // the transaction layer reuses the credentialed one it already holds.
let file_io = self
- .load_file_io(Some(&response.metadata_location), None)
+ .load_file_io(Some(&response.metadata_location), None, None)
Review Comment:
Wonder what the risks are here of not creating FileIo here without the
credentials? Is that idea that after we have credential refresh we will just
automatically refresh on the next read / write?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
