kinolaev commented on issue #16445: URL: https://github.com/apache/iceberg/issues/16445#issuecomment-5446582535
@manuzhang, @dramaticlly, shouldn't `org.apache.iceberg.avro.Avro.ReadBuilder.createReaderFunc` and `org.apache.iceberg.avro.ProjectionDatumReader` also be removed? It seems like they were used only with `DataReader`, but now the `org.apache.iceberg.avro.TestReadDefaultValues.testDefaultDoesNotOverrideExplicitValue` test is the only caller. And the test succeed without `.createReaderFunc(GenericAvroReader::create)` call, because `GenericAvroReader` is the default reader in `Avro.ReadBuilder`. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
