dbtsai commented on code in PR #17236: URL: https://github.com/apache/iceberg/pull/17236#discussion_r3876857563
########## api/src/test/java/org/apache/iceberg/metrics/CachingMetricsContext.java: ########## @@ -16,32 +16,19 @@ * specific language governing permissions and limitations * under the License. */ -package org.apache.iceberg.rest; +package org.apache.iceberg.metrics; -import java.util.List; import java.util.Map; -import org.immutables.value.Value; +import org.apache.iceberg.relocated.com.google.common.collect.Maps; -/** Configuration for remote signer clients. */ [email protected] -public interface RemoteSigningConfig { +/** A {@link MetricsContext} that hands out the same counter per name so tests can read it back. */ +public class CachingMetricsContext extends DefaultMetricsContext { + // The counter type is fully qualified: the inherited nested MetricsContext.Counter would Review Comment: Done in eba32a18 — removed the explanatory comment. Kept the fully-qualified `org.apache.iceberg.metrics.Counter` on the field and return type so the inherited nested `MetricsContext.Counter` doesn't shadow it and re-break `compileTestJava`. Thanks for the reviews! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
