Copilot commented on code in PR #2: URL: https://github.com/apache/iceberg-verification/pull/2#discussion_r3876857339
########## CONTRIBUTING.md: ########## @@ -0,0 +1,215 @@ +<!-- + ~ Licensed to the Apache Software Foundation (ASF) under one + ~ or more contributor license agreements. See the NOTICE file + ~ distributed with this work for additional information + ~ regarding copyright ownership. The ASF licenses this file + ~ to you under the Apache License, Version 2.0 (the + ~ "License"); you may not use this file except in compliance + ~ with the License. You may obtain a copy of the License at + ~ + ~ http://www.apache.org/licenses/LICENSE-2.0 + ~ + ~ Unless required by applicable law or agreed to in writing, + ~ software distributed under the License is distributed on an + ~ "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY + ~ KIND, either express or implied. See the License for the + ~ specific language governing permissions and limitations + ~ under the License. + --> + +# Contributing + +First, thank you for contributing to iceberg-verification! The goal of this +document is to provide the guidelines you need to maintain a high quality +verification framework for all Iceberg implementations. + +[Iceberg](https://iceberg.apache.org/) is first and foremost a Spec, an +agreement between different implementations on the structure and meaning of the +artifacts that make up a table. And as such, it is crucial that the way each +implementation interprets the spec, and the values and artifacts it stores and +transfers as a result, stay consistent across implementations. Each +implementation's own test suite cannot catch a divergence here, because it +checks that implementation against its own reading of the spec. + +This framework aims to become a central place where the materialized value +expectations of the spec are discussed, so that their representations and +expectations can be used to verify implementations across languages and +platforms. + +One thing to be clear about up front: we surface ambiguity here, we do not +settle it here. When a case has no clear answer in the spec, take it to +[[email protected]](https://lists.apache.org/[email protected]) +first, and commit the fixture once the community has agreed on the answer. + +## Does your change belong here? + +This repository holds artifacts and the expected values the spec fixes for +them. It holds no implementation code, and it verifies no behavior. Review Comment: The statement that the repo "holds no implementation code" and "verifies no behavior" conflicts with the repository README, which describes this as a verification framework with runners that exercise fixtures. Consider rewording to avoid an absolute claim and align with the README’s positioning. ########## .asf.yaml: ########## @@ -53,6 +53,9 @@ github: issues: false wiki: false projects: false + + collaborators: # Note: the number of collaborators is limited to 10 Review Comment: There is trailing whitespace on the blank line before `collaborators:` (line 56). This can cause unnecessary diffs and may trip whitespace/lint checks; prefer an empty line with no spaces. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
