singhpk234 commented on code in PR #17855:
URL: https://github.com/apache/iceberg/pull/17855#discussion_r3878119988


##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -5123,6 +5123,25 @@ components:
           "values": [ 100, 200 ]
         }
 
+    IntegerMap:
+      type: object
+      properties:
+        keys:
+          type: array
+          items:
+            $ref: '#/components/schemas/IntegerTypeValue'
+          description: "List of integer column ids for each corresponding 
value"
+        values:
+          type: array
+          items:
+            $ref: '#/components/schemas/IntegerTypeValue'
+          description: "List of integer values, matched to 'keys' by index"
+      example:
+        {
+          "keys": [ 1, 2 ],
+          "values": [ 8, 16 ]
+        }

Review Comment:
   can't we use ValueMap ? like what we use for other stats
   
https://github.com/apache/iceberg/blob/ef8a69dc3dab5858d612770062bbf5a6043170f0/open-api/rest-catalog-open-api.yaml#L5126
 



##########
open-api/rest-catalog-open-api.yaml:
##########
@@ -5222,6 +5241,12 @@ components:
           description: "List of splittable offsets"
         sort-order-id:
           type: integer
+        avg-value-sizes:
+          allOf:
+            - $ref: '#/components/schemas/IntegerMap'
+          description:
+            Map of column id to average value size in memory (uncompressed) in
+            bytes over non-null values

Review Comment:
   would this be part of data file ? like lower / upper bound are ?



-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to