JanKaul opened a new pull request, #3087:
URL: https://github.com/apache/iceberg-rust/pull/3087

   ## Which issue does this PR close?
   
   None — this is additional test coverage.
   
   ## What changes are included in this PR?
   
   `ArrowReader` already loads and applies both position and equality deletes, 
but the existing tests cover the loader / predicate / row-group pieces in 
isolation. There's no end-to-end coverage (`read()` → assert surviving rows) 
for scenarios that **combine or stack** delete files.
   
   This adds an `arrow::reader::delete_application` test module with five 
end-to-end tests:
   
   - a single equality delete removes exactly the matching rows;
   - **multiple equality delete files** targeting one data file (keys unioned);
   - **multiple position delete files** targeting one data file (positions 
unioned);
   - **mixed** position + equality deletes on the same data file;
   - a **fully-deleted** data file yields no rows.
   
   Each test writes a small data file and its delete file(s) to a `TempDir`, 
reads them through `ArrowReader::read()` with a local-filesystem `FileIO`, and 
asserts the surviving `id`s.
   
   ## Are these changes tested?
   
   Yes — the five new tests pass (`cargo test -p iceberg`). They use only the 
public reader API (`ArrowReaderBuilder`, `FileScanTask`, 
`FileScanTaskDeleteFile`, `FileIO::new_with_fs`) and need no external services.


-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: [email protected]

For queries about this service, please contact Infrastructure at:
[email protected]


---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]

Reply via email to