jackye1995 commented on a change in pull request #1872:
URL: https://github.com/apache/iceberg/pull/1872#discussion_r555364988
##########
File path: api/src/main/java/org/apache/iceberg/ManifestFile.java
##########
@@ -199,6 +200,16 @@ default boolean hasDeletedFiles() {
*/
boolean containsNull();
+ /**
+ * Returns true if at least one data file in the manifest has a nan value
for the field.
+ * Null if this information doesn't exist.
+ * <p>
+ * Default to return null to ensure backward compatibility.
+ */
+ default Boolean containsNaN() {
+ return null;
Review comment:
Just going back to the discussion of default to make sure my
understanding is correct, if the returned value is null, does it mean the
manifest file would suggest the data file does not contain NaN?
This behavior seems consistent with the default `false` in
`PartitionSummary.java`, but logically speaking it seems like returning true as
default is more reasonable to suggest a file always might contain NaN. What is
the take here?
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
