gaborkaszab commented on PR #17843: URL: https://github.com/apache/iceberg/pull/17843#issuecomment-5450548397
Thanks for opening this @ebyhr ! After I went through the description and checked how `suppressHistoricalSnapshots` works, I feel that the issue is not with `CatalogHandlers` not calling `discardChanges()`. What I'd like to rather scratch is if we should create any statistics removal events when in a "suppress" mode in `TableMetada.rewriteSnapshotsInternal()`. I don't think so. Not creating removal events in "suppress" mode (similarly as we don't create `RemoveSnapshots` events either) would solve the issue, right? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
