laskoviymishka commented on issue #1929: URL: https://github.com/apache/iceberg-go/issues/1929#issuecomment-5450796785
Thanks for driving this! Direction looks right to me, and the PR breakdown is a sane dependency order (could be executed as a stack PR imo). One thing I'd settle before code: the test strategy around Java compatibility. I'd bake the Java-authored bytes into the repo and keep the tests Java-less, rather than standing up a JVM on the test path. That's already the pattern the DV code uses, and I think it's worth cloning that approach exactly: the Puffin fixtures live under `table/dv/testdata`, and the x-client tests read those bytes back through the reader with no Java at test time. I read the "same as DV approach" line to mean this already, but worth being explicit so nobody wires a Gradle build into go-CI :D. Separately, cc @nssalian: this is exactly the x-client byte parity that `apache/iceberg-verification` is for (see: [[VOTE](https://lists.apache.org/thread/98ntkfmtrqhfj5w54x27tnxfq14fftqb)](https://lists.apache.org/thread/98ntkfmtrqhfj5w54x27tnxfq14fftqb)). I think the Theta/NDV parity vectors are a strong early candidate to live in the verification repo. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
