GaspardMerten commented on PR #3862: URL: https://github.com/apache/iceberg-python/pull/3862#issuecomment-5451280341
Hey @hedger9487, Thanks for the review. For 1, the function was called only when the types matched; it wouldn't have caused a bug, but if it were used elsewhere, it could, so I followed your advice. On 2, my opinion is to keep the code as is, or, if needed, to refactor the except branch into a separate function, as it really is a fallback for the limitations of `not_equal`, which might evolve over the years. We shouldn't treat this as normal, but hope it gets fixed someday. Hence, in a way, the current approach feels in mho more adapted to the situation; what do you think? -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
