joyhaldar commented on code in PR #17610:
URL: https://github.com/apache/iceberg/pull/17610#discussion_r3880822917
##########
data/src/test/java/org/apache/iceberg/data/ReadFormatModelTests.java:
##########
@@ -1343,7 +1347,7 @@ void testReadMetadataColumnRowPosition(FileFormat
fileFormat) throws IOException
@ParameterizedTest
@FieldSource("FILE_FORMATS")
void testReadMetadataColumnIsDeleted(FileFormat fileFormat) throws
IOException {
-
+ assumeFalse(supportsBatchReads(), "DeletedColumnVector requires a delete
filter");
Review Comment:
It doesn't return `false`, it throws:
```
TestSparkVectorizedFormatModel > testReadMetadataColumnIsDeleted(FileFormat)
> [2] PARQUET FAILED
java.lang.NullPointerException: Cannot load from byte/boolean array
because "this.isDeleted" is null
at
org.apache.iceberg.spark.data.vectorized.DeletedColumnVector.getBoolean(DeletedColumnVector.java:61)
at
org.apache.spark.sql.vectorized.ColumnarBatchRow.getBoolean(ColumnarBatchRow.java:108)
at
org.apache.spark.sql.vectorized.ColumnarBatchRow.get(ColumnarBatchRow.java:181)
at
org.apache.iceberg.spark.data.TestHelpers.assertEquals(TestHelpers.java:772)
at
org.apache.iceberg.spark.data.TestHelpers.assertEquals(TestHelpers.java:734)
at
org.apache.iceberg.spark.data.TestHelpers.assertEquals(TestHelpers.java:719)
at
org.apache.iceberg.spark.data.TestSparkVectorizedFormatModel.assertRecordsEqual(TestSparkVectorizedFormatModel.java:102)
```
The array is only filled when a delete filter is set IIUC. ORC passes, so
this is Parquet only if I am not wrong. I will fix the message. Should I file
an issue for this, or send a fix PR? Please correct me if I am wrong.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
