yyanyy commented on a change in pull request #1790:
URL: https://github.com/apache/iceberg/pull/1790#discussion_r555457586
##########
File path: orc/src/main/java/org/apache/iceberg/orc/OrcRowWriter.java
##########
@@ -35,4 +37,9 @@
* @throws IOException if there's any IO error while writing the data value.
*/
void write(T row, VectorizedRowBatch output) throws IOException;
+
+ /**
+ * Returns a stream of {@link FieldMetrics} that this OrcRowWriter keeps
track of.
+ */
+ Stream<FieldMetrics> metrics();
Review comment:
Currently value writers all have a default, and this is because we are
only tracking this metrics for float and wrapper types, declaring a default
will save other types from declaring empty stream. This row writer on the other
hand handles row writing, and it will always need to read from value writers'
metrics, and thus default wouldn't help much on this aspect. Although I guess
we want to prevent breaking people's code if they implement their own version
of row writer, that I'll add a default here to avoid that.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
