blackmwk commented on code in PR #3090:
URL: https://github.com/apache/iceberg-rust/pull/3090#discussion_r3885122265
##########
crates/iceberg/src/io/file_io.rs:
##########
@@ -59,13 +60,14 @@ use crate::Result;
/// .with_prop("key", "value")
/// .build();
/// ```
-#[derive(Clone, Debug)]
+#[derive(Clone, Debug, Serialize, Deserialize)]
pub struct FileIO {
/// Storage configuration containing properties
config: StorageConfig,
Review Comment:
I don't think the credentials is a problems and we can't redact them for
several reasons:
1. They are typically short live tokens, for example in rest catalog it's
genrated by rest server
2. We need to use them reconstruct storage in another process, for example
in worker
3. The typical use case is to use them in rpc of a distributed system. If
security is a problem, the correct approach is to encrypt the rpc rather than
doing it in this library. iceberg-rust is a library embeded in other systems,
so I don't think we should do too much here.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
