Vinodh247 commented on code in PR #17827: URL: https://github.com/apache/iceberg/pull/17827#discussion_r3887117632
########## docs/docs/spark-writes.md: ########## @@ -218,8 +218,11 @@ For more complex row-level updates based on incoming data, see the section on `M ## Writing to Branches -The branch must exist before performing write. Operations do **not** create the branch if it does not exist. -A branch can be created using [Spark DDL](spark-ddl.md#branching-and-tagging-ddl). +A branch can be created during a write if it does not already exist. + +A branch can also be created using [Spark DDL](spark-ddl.md#branching-and-tagging-ddl). + +When writing to a branch, the branch specified in the table identifier and the `branch` write option must match if both are specified. An explicit branch takes precedence over the session WAP branch configured with `spark.wap.branch`. If no explicit branch is specified and WAP is enabled, the session WAP branch is used. Review Comment: hi uros-b: thanks for catching this. you are right that the behaviour differs between spark 3.5/4.0 & spark 4.1, while the current documentation is not version specific. I will scope the precedence statement to spark 4.1 and update the PR accordingly. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
