damansingh1313 opened a new pull request, #17904: URL: https://github.com/apache/iceberg/pull/17904
Five methods (create(Dataset), setParameters, removeParameters, create(Table), update) each repeated the same block: a call to BigQueryRetryHelper.runWithRetries(...) passing the same six retry/telemetry settings, followed by an identical catch that forwards to handleBigQueryRetryException. Extract that block into a private generic runWithRetries(Callable<T>) helper and call it from all five sites. Behavior is unchanged; the only difference is that the previously-unreachable fall-through after handleBigQueryRetryException (which always throws) now raises IllegalStateException instead of returning a null Dataset/Table. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
