talatuyarer commented on code in PR #17878:
URL: https://github.com/apache/iceberg/pull/17878#discussion_r3896714096
##########
flink/v2.3/flink/src/main/java/org/apache/iceberg/flink/source/IcebergTableSource.java:
##########
@@ -61,7 +68,23 @@ public class IcebergTableSource
SupportsProjectionPushDown,
SupportsFilterPushDown,
SupportsLimitPushDown,
- SupportsSourceWatermark {
+ SupportsSourceWatermark,
+ SupportsStatisticReport {
+
+ private static final Logger LOG =
LoggerFactory.getLogger(IcebergTableSource.class);
+
+ // statistics are computed for the current table state only; these options
change what is read
+ private static final Set<String> TIME_TRAVEL_OPTIONS =
Review Comment:
I didn't like it either 🙂 Reworked it the hardcoded list is gone entirely.
How looks like now ?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
