yangshangqing95 commented on code in PR #17894:
URL: https://github.com/apache/iceberg/pull/17894#discussion_r3897004771
##########
hive-metastore/src/test/java/org/apache/iceberg/hive/TestHiveCatalog.java:
##########
@@ -305,6 +305,23 @@ public void testInitializeCatalogWithProperties() {
.isEqualTo("/user/hive/testwarehouse");
}
+ @Test
+ public void testConstructorWithConfAndProperties() {
Review Comment:
Nit: for a newly added test, the current Iceberg test conventions prefer
package-private test methods without the test prefix, so this could be:
```
@Test
void constructorWithConfAndProperties() {
```
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
