xanderbailey commented on code in PR #3093:
URL: https://github.com/apache/iceberg-rust/pull/3093#discussion_r3896710206
##########
crates/iceberg/src/spec/table_properties.rs:
##########
@@ -336,6 +350,15 @@ pub struct TableProperties {
getter
)]
write_object_storage_partitioned_paths: bool,
+ /// The table's default name mapping, used to assign field ids when
reading data files
+ /// that carry no field id metadata. `None` if
`schema.name-mapping.default` is not set.
+ #[property(
+ key = Self::PROPERTY_DEFAULT_NAME_MAPPING,
+ default = None,
+ parse_with = parse_name_mapping,
+ getter
+ )]
+ default_name_mapping: Option<Arc<NameMapping>>,
Review Comment:
[5853c0e](https://github.com/apache/iceberg-rust/pull/3093/commits/5853c0e6ad0d121c9271e3f4c1d14d1ba3479e4d)
##########
crates/iceberg/src/spec/table_properties.rs:
##########
@@ -32,6 +34,18 @@ fn parse_location_property(path: &str) -> Result<String> {
Ok(strip_trailing_slash(path).to_string())
}
+fn parse_name_mapping(value: &str) -> Result<Arc<NameMapping>> {
Review Comment:
[5853c0e](https://github.com/apache/iceberg-rust/pull/3093/commits/5853c0e6ad0d121c9271e3f4c1d14d1ba3479e4d)
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
