hedger9487 commented on PR #3842: URL: https://github.com/apache/iceberg-python/pull/3842#issuecomment-5483727241
Thanks for the suggestion, @kevinjqliu! Connecting this fix with a future `rewrite_manifest` maintenance action is a great point that I hadn't considered. I have updated the PR to align with this proposal: 1. **Write path**: Corrected `equality_ids` in `DATA_FILE_TYPE` to `IntegerType` (element ID 136). 2. **Read path**: Tolerated `Long -> Int` strictly for manifest `DataFile` `equality_ids` (element ID 136) in `ReadSchemaResolver.primitive`, ensuring backwards compatibility for legacy manifests without leaking type relaxation to user tables or other fields. 3. **Tests**: Added coverage for writing compliant `int` manifests, reading legacy `long` manifests, and verifying resolver isolation. All tests and pre-commit checks are passing cleanly. I'll also be working on the `rewrite_manifests` maintenance operation in a follow-up PR next. Ready for another review whenever convenient, thanks! -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
