zeroshade commented on PR #1965: URL: https://github.com/apache/iceberg-go/pull/1965#issuecomment-5487570769
Heads-up: my approval above stands, but this went conflicted before I could merge it. The cause is the duplicated `schema.go` `MarshalJSON` lazy-cache fix that this PR shares with #1960, #1962, #1963 and #1964. Those four landed first, so the identical hunk here now conflicts. A rebase onto current `main` should drop that hunk entirely and leave just the partition-projection reuse. Once rebased and green I'll merge it — no need to re-request review. The minor test-strengthening note from my review is still worth picking up, either here or as a follow-up. For future stacks: carrying the same incidental fix across several PRs guarantees that all but the first conflict. Landing it once on its own, ahead of the stack, avoids the churn. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
