zeroshade commented on PR #1976: URL: https://github.com/apache/iceberg-go/pull/1976#issuecomment-5488389139
My approval above stands, but this went conflicted before I could merge it. #1781 (`reuse FileIO during local scan planning`) landed first and also edits `table/scanner.go` — specifically `collectManifestEntriesWithSchema`, which this PR restructures. That's the overlap I noted in the review. The duplicated `schema.go` lazy-cache hunk is also on `main` now and should drop out. A rebase onto current `main` should resolve both. The one thing to check while rebasing: #1781 introduced `manifestIOBatch` acquisition inside the same collector loop this PR converts to per-manifest result slots, so please confirm the batch `acquire` call still sits inside the worker (and still sees the errgroup context) once the slots refactor is reapplied. Also worth sequencing against #1974, which is approved and awaiting its own rebase and touches the same collector from the streaming side. Once rebased and green I'll merge — no need to re-request review. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
