blackmwk commented on code in PR #3090:
URL: https://github.com/apache/iceberg-rust/pull/3090#discussion_r3901161017
##########
crates/iceberg/src/io/file_io.rs:
##########
@@ -69,6 +70,18 @@ pub struct FileIO {
storage: Arc<OnceLock<Arc<dyn Storage>>>,
}
+#[derive(Serialize)]
+struct SerializableFileIO<'a> {
+ config: &'a StorageConfig,
+ factory: &'a Arc<dyn StorageFactory>,
+}
+
+#[derive(Deserialize)]
+struct DeserializedFileIO {
+ config: StorageConfig,
+ factory: Arc<dyn StorageFactory>,
+}
+
Review Comment:
Addressed in
[4b426339](https://github.com/apache/iceberg-rust/pull/3090/commits/4b4263395).
Both wire structs and their serde imports now live in a private `_serde`
module; only the parent `file_io` module can access them.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
