JanKaul commented on PR #2620: URL: https://github.com/apache/iceberg-rust/pull/2620#issuecomment-5493522050
I also like the design proposed in the new RFC. One thing worth flagging: the validation step was significantly reduced compared to the previous document — the new RFC nails down when and where validation runs (attempt-local, before any I/O), but the actual conflict predicates that the previous doc spelled out are no longer covered. We should keep that in mind and make sure the different conflict predicates (conflicting appends, conflicting deletes, added-files-match-filter, files-exist, etc.) are all captured, either here or in a companion doc. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
