RussellSpitzer commented on code in PR #15989:
URL: https://github.com/apache/iceberg/pull/15989#discussion_r3906490487
##########
core/src/test/java/org/apache/iceberg/rest/TestResourcePaths.java:
##########
@@ -176,6 +193,22 @@ public void
testNamespacePropertiesWithMultipartNamespace() {
assertThat(withoutPrefix.namespaceProperties(ns)).isEqualTo("v1/namespaces/n%1Fs/properties");
}
+ @Test
Review Comment:
This PR is already pretty large, do we need a separate test for both " " and
"+" for every endpoint? Couldn't we just do "foo +bar" and cover everything at
once? We have coverage for the individual correctness in the utility, here we
just want to make sure the right encoder was used.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
