shaynhornik opened a new pull request, #3893:
URL: https://github.com/apache/iceberg-python/pull/3893
Closes #3877
# Rationale for this change
Follow-up to the 0.12.0 release vote thread findings on the wheel's LICENSE
documentation:
1. **Vendored paths were wrong in binary distributions.** `setup.py` maps
`vendor/fb303` and `vendor/hive_metastore` to top-level `fb303` and
`hive_metastore` packages via `package_dir`, so the LICENSE entries saying the
code lives "in vendor/fb303/" were only accurate for the source distribution.
Both entries now describe each layout explicitly ("located in vendor/… in the
source distribution and shipped as the top-level … package in binary
distributions"), so the one LICENSE file that `license-files` ships into both
artifacts is accurate in both.
2. **The bundled Cython runtime was undocumented.** The compiled
`pyiceberg.avro.decoder_fast` extension embeds the Cython runtime code that
Cython generates into every compiled module. Cython is Apache-2.0 licensed with
no NOTICE file, so a LICENSE entry (no NOTICE change) documents it, following
the format of the existing entries.
## Are these changes tested?
Verified by building a wheel from this branch and inspecting it:
- `fb303/` and `hive_metastore/` are at the wheel root (no `vendor/`
directory), matching the new wording.
- The updated LICENSE lands at `pyiceberg-0.12.0.dist-info/licenses/LICENSE`
with both fixes present.
- `strings` on the built `decoder_fast` `.so` confirms embedded Cython
runtime code.
- `dev/check-license` (RAT) checks source headers only, so it is unaffected.
## Are there any user-facing changes?
No code changes; LICENSE documentation only.
---
*AI disclosure: this change was developed with the assistance of Claude
Code, per the repository's agent workflow (AGENTS.md). I reviewed the analysis
and the wording, and verified the built wheel myself; I take responsibility for
the contribution.*
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
