RussellSpitzer commented on PR #15895: URL: https://github.com/apache/iceberg/pull/15895#issuecomment-5500813049
I think we probably should tie in the core changes in this PR since we are the main consumer of this API and it's really small. But i'm also ok with just merging this. @danielcweeks do you have any other feedback here ? Are you happy with the builder approach or are you looking for a more context specific type system. I was kind of considering requesting something like List<Context> where we have subclasses for the Contexts being passed (ReferencedByContext, ...) But honestly I'm not sure we will extend this all that much so the Builder seems pretty much fine to me. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
