Fokko commented on PR #3658: URL: https://github.com/apache/iceberg-python/pull/3658#issuecomment-5505671877
> One thought: a simpler alternative might be to convert fetch_manifest_entry into a generator instead of adding entry_filter. That way _open_manifest keeps its existing comprehension filter and the memory win comes for free, with no new parameter. It would be a wider change though, so not sure what maintainers would prefer here. In hindsight this might have been a better approach, but that would change the signature. For example, I can see folks doing a `len(..)` operation, but that's not possible on a generator and would raise an exception. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
