chiragkava commented on code in PR #17742:
URL: https://github.com/apache/iceberg/pull/17742#discussion_r3911646901
##########
arrow/src/test/java/org/apache/iceberg/arrow/vectorized/TestArrowReader.java:
##########
@@ -389,6 +391,43 @@ public void testTimestampMillisAreReadCorrectly() throws
Exception {
assertThat(totalRowsRead).as("Should read all
rows").isEqualTo(millisValues.size());
}
+ @Test
+ public void testReleasesDecodedVectorsWhenDictEncodedBatchIsMaterialized()
throws Exception {
+ Table table = createDictEncodedTable();
+ long allocatedBefore =
ArrowAllocation.rootAllocator().getAllocatedMemory();
Review Comment:
Added the constructor overload you suggested both tests uses their own
RootAllocator and assert on that.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
