yyanyy commented on pull request #2058: URL: https://github.com/apache/iceberg/pull/2058#issuecomment-759069297
> > I appreciate taking the time to keep the code clean, but I generally like to avoid commits that could cause conflicts simply to fix whitespace. It isn't unclear what the comment applies to, so I don't think that we should make this change. > > @yyanyy can you include this change in one of your commits? I think you added that comment line Yes, sorry I introduced this. I think currently I don't have any PR that touches this file though, and I think #2062 will likely modify this class; should we do it there instead so that we won't have conflict when either PR got merged? ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
