Fokko commented on code in PR #3666:
URL: https://github.com/apache/iceberg-python/pull/3666#discussion_r3915647836
##########
pyiceberg/expressions/visitors.py:
##########
@@ -1785,7 +1785,7 @@ def _can_contain_nans(self, field_id: int) -> bool:
return (nan_count := self.nan_counts.get(field_id)) is not None and
nan_count > 0
-class ResidualVisitor(BoundBooleanExpressionVisitor[BooleanExpression], ABC):
Review Comment:
The constructors are the same, but the new `ResidualVisitor` is no longer a
visitor. I don't think that's very nice to our downstream consumers, who
_might_ be using the visitor. Do we really need to make the split?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
