RussellSpitzer commented on code in PR #17918:
URL: https://github.com/apache/iceberg/pull/17918#discussion_r3917587996
##########
format/spec.md:
##########
@@ -569,7 +597,7 @@ Partition field IDs must be reused if an existing partition
spec contains an equ
| Transform name | Description
| Source types
| Result type |
|-------------------|--------------------------------------------------------------|-----------------------------------------------------------------------------------------------------------|-------------|
-| **`identity`** | Source value, unmodified
| Any primitive except for `geometry` and `geography` | Source type |
+| **`identity`** | Source value, unmodified
| Any primitive except for `geometry`, `geography`, and `file` | Source
type |
Review Comment:
I agree with Anoop here, I think the Variant comparison is pretty good. It
has a well defined structure and type but doesn't behave like a primitive (no
single value serialization, no defaults) instead it behaves like a struct or
variant. I don't want to bikeshed on this though since it's really just a
naming issue I think. We agree on the behaviors
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
