anuragmantri commented on code in PR #17928:
URL: https://github.com/apache/iceberg/pull/17928#discussion_r3917529551
##########
api/src/main/java/org/apache/iceberg/DataFile.java:
##########
@@ -164,4 +164,9 @@ default FileContent content() {
default List<Integer> equalityFieldIds() {
return null;
}
+
+ /** Returns the deletion vector co-located with this data file, or null if
there is none. */
Review Comment:
Do you think it is worth adding this happens starting V4 and V3 and below,
null does not mean there are no deletes, just that the should be read from the
FileScanTask?
##########
api/src/main/java/org/apache/iceberg/DataFile.java:
##########
@@ -164,4 +164,9 @@ default FileContent content() {
default List<Integer> equalityFieldIds() {
return null;
}
+
+ /** Returns the deletion vector co-located with this data file, or null if
there is none. */
+ default DeleteFile deletionVector() {
Review Comment:
I would argue other way. Deletion Vector is an implementation. Should we
instead just call `DataFile.deletes()` which is agnostic of implementation?
##########
api/src/main/java/org/apache/iceberg/DataFile.java:
##########
@@ -164,4 +164,9 @@ default FileContent content() {
default List<Integer> equalityFieldIds() {
return null;
}
+
+ /** Returns the deletion vector co-located with this data file, or null if
there is none. */
+ default DeleteFile deletionVector() {
+ return null;
Review Comment:
Question: In the `V4ManifestReader`, is it possible that a projection omits
dv field id? Should we always include ` TrackedFile.DELETION_VECTOR.fieldId()`?
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
