vbhanuchander-lang commented on issue #17340: URL: https://github.com/apache/iceberg/issues/17340#issuecomment-5518310577
Thanks @ericyangliu — opened #17933. It is the `put` → `merge(..., Long::max)` change you suggested, nothing more. The argument I made for it in the PR is that `Coordinator.commitToTable` already folds `controlTopicOffsets()` with `Long::max` against the last committed offsets, so making the map itself monotonic only brings it in line with how its two consumers — that stamp and `commitConsumerOffsets()` — already treat it. The forward path is unchanged. On the open question I raised above about whether the offset fix is sufficient on its own: I still cannot settle it from the code, so I have kept the bounded recently-committed-locations set out of the PR and flagged it there as a separate design call. That keeps the correctness fix reviewable on its own, and it is your call whether you want to pursue the backstop. The diagnosis and the production evidence in this issue are yours, and the PR says so. -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected] --------------------------------------------------------------------- To unsubscribe, e-mail: [email protected] For additional commands, e-mail: [email protected]
