vbhanuchander-lang commented on PR #17080:
URL: https://github.com/apache/iceberg/pull/17080#issuecomment-5518397116
@thswlsqls this was closed by the stale bot on 28 Aug, not on merit — it was
never reviewed by
anyone. The bug is still on `main` and your fix is correct. I verified it
end to end so a committer
has less to redo:
**The bug is real and current.** `addReady()` buffers every `DataComplete`
unconditionally
(`CommitState.java:63`), while the very next branch filters by `commitId` for
`receivedPartitionCount` (line 68). `validThroughTs()` then reads that
unfiltered buffer, so a
zombie coordinator's stale event still reaches it on `main` today. Your
framing is the convincing
one: #16453 applied this filter to `receivedPartitionCount` and
`isCommitReady()` and left
`validThroughTs()` behind, so this is finishing that change rather than a
new idea.
**Verified against `8ea7d00` (main, 3 Sep):**
- the patch applies cleanly with no conflicts
- `TestCommitState` passes with it, 5 tests
- reverting only `CommitState.java` and keeping your test fails with
`expected: 2026-09-03T00:19:38.829847Z but was: null` — so
`testGetValidThroughTsIgnoresZombieCoordinatorPayloads` genuinely guards
the change rather than
passing either way
- the whole `iceberg-kafka-connect` module is green, 136 tests
The null timestamp in your zombie payload is what makes the test bite: it
flips `hasValidThroughTs`
to false and nulls the whole result, so the stale event does not merely
shift the watermark, it
erases `kafka.connect.valid-through-ts` from the snapshot.
The bot's message says the PR can be revived at any time. @bryanck would you
be willing to reopen
it? Happy to answer anything on the verification, but the change is
@thswlsqls's and should stay
theirs.
--
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
To unsubscribe, e-mail: [email protected]
For queries about this service, please contact Infrastructure at:
[email protected]
---------------------------------------------------------------------
To unsubscribe, e-mail: [email protected]
For additional commands, e-mail: [email protected]
